nyxiereal / ReVancedPacker

RVP - ReVanced APK Compiler written in Python 3.11.4
GNU General Public License v2.0
298 stars 24 forks source link

RVP.py: "Line 85: TypeError: type NoneType doesn't define __round__ method" #46

Closed Spacellary closed 1 year ago

Spacellary commented 1 year ago

Describe the bug Running RVP.py causes "Line 85: TypeError: type NoneType doesn't define round method"

To Reproduce Steps to reproduce the behavior:

  1. python RVP.py
  2. See error

Expected behavior Proceeding normally to the next steps.

Log:

Traceback (most recent call last):
  File "D:\Browser-Downloads\Edge-Downloads-2023.1.2\RVP.py", line 255, in <module>
    main()
  File "D:\Browser-Downloads\Edge-Downloads-2023.1.2\RVP.py", line 85, in main
    f"Internet: {str(round(ping('github.com', unit='ms'), 2))}ms\n\n"
TypeError: type NoneType doesn't define __round__ method

Desktop (please complete the following information):

Java: openjdk 17.0.6 2023-01-17 LTS OpenJDK Runtime Environment Zulu17.40+19-CA (build 17.0.6+10-LTS) OpenJDK 64-Bit Server VM Zulu17.40+19-CA (build 17.0.6+10-LTS, mixed mode, sharing)

Additional context Running RVP.py from latest 2.8 release

Maybe a fix? Replacing line 85 with something like this f"Internet: {str(round(ping('github.com', unit='ms'), 2)) if ping('github.com', unit='ms') is not None else 'N/A'}ms\n\n" did allow me to proceed to next steps.

nyxiereal commented 1 year ago

get better internet

nyxiereal commented 1 year ago

nah but fr try restarting your router and pc

Spacellary commented 1 year ago

It's fine, if it can't be reproduced it's an issue on my end then.