[FEATURE REQUEST] - shell completion

[nyxnor]

Is your feature request related to a problem? Please describe.

Those are the most used shells and known to me that have completion (more to come if someone helps), I want that to be improved.

• https://github.com/nyxnor/onionservice/blob/main/etc/bash_completion/onionservice-cli
• https://github.com/nyxnor/onionservice/tree/main/etc/zsh_completion

Describe the solution you'd like

• Bash completion official package and debian guide

• Zsh completion example https://github.com/cheat/cheat/blob/master/scripts/cheat.zsh

Additional context

Low priority, it will be very useful but not intrinsic required.

• only bash, https://unix.stackexchange.com/a/158523
• https://maskedbyte.com/how-to-create-a-custom-bash-completion-script/

[nyxnor]

Planning to move this to a new repository onionjuggler-shell-completion This will avoid having bash and zsh code with posix, because of shellcheck and codefactor lintering.

[nyxnor]

• https://zsh.sourceforge.io/FAQ/zshfaq04.html#l54
• https://github.com/zsh-users/zsh-completions/blob/master/zsh-completions-howto.org
• https://zsh.sourceforge.io/Doc/Release/Completion-System.html

[nyxnor]

https://github.com/scop/bash-completion/blob/master/bash_completion

[nyxnor]

9a00d26

[nyxnor]

8d36854

[nyxnor]

ca13e72

[nyxnor]

in the end it was only bash completion, because sh does not have one and I won't learn zsh completion.

Also, only possible to complete services by configuration, because it is readable.

Not possible to complete clients server and client side because it is owned by the tor user.

Also, if the completion was made, it would only be valid to the root user, and I don't want anyone running root user by default just for completion.

[nyxnor]

What can be improved is service listing with comma the same way wget does https://github.com/scop/bash-completion/blob/40aa4dc3c75791f43f850871466039768b3048ad/completions/wget#L47