nyxx-discord / nyxx

Wrapper around Discord API for Dart

Apache License 2.0

326 stars 49 forks source link

Add more methods on models, bugfixes #628

Closed MCausc78 closed 7 months ago

MCausc78 commented 7 months ago

Description

Added more docs for manager methods
Added more methods on models
Added auditLogReason to StickerManager methods, and WebhookManager.update as well
Added includeId param in PermissionOverwriteBuilder.build() to make payloads more correct
Fix interactionsEndpointUrl being ignored in ApplicationUpdateBuilder
Fix auditLogReason in EmojiManager methods

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] Ran dart analyze or make analyze and fixed all issues
[x] Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

abitofevrything commented 7 months ago

Still waiting on https://github.com/discord/discord-api-docs/pull/6484, but looks good otherwise.

MCausc78 commented 7 months ago

OpenAPI spec says that interactions_endpoint_url/role_connections_verification_url can be nullable:

https://github.com/discord/discord-api-spec/blob/fe9917381e47285b56d98cb72ae3cfe7db9ea19c/specs/openapi.json#L194-L251
https://github.com/discord/discord-api-spec/blob/fe9917381e47285b56d98cb72ae3cfe7db9ea19c/specs/openapi.json#L10944-L10951 Can that be counted as "acknowledged by discord"?