nyxx-discord / nyxx

Wrapper around Discord API for Dart

Apache License 2.0

326 stars 49 forks source link

Correct the user agent used by default #633

Closed abitofevrything closed 8 months ago

abitofevrything commented 8 months ago

Description

Nyxx's default user agent doesn't match Discord's documentation. This PR fixes that.

See https://discord.com/developers/docs/reference#user-agent. Other libraries (I checked discord.js, discord.py and JDA) all use the DiscordBot prefix, so this is likely a misinterpretation on our end.

Thanks to @MCausc78 for finding this.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] Ran dart analyze or make analyze and fixed all issues
[x] Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works