search

nyxxxie / serenity

Universal guided editor and reverse engineering tool for binary data.
GNU General Public License v3.0
11 stars 3 forks source link

changes_comments should have compound foreign key (file_id, hash) #23

Closed nanokatze closed 7 years ago

nanokatze commented 7 years ago

There can exist same change hash for two or more different files. Example:

  1. you open two files with exactly same content
  2. their base changes are both 0
  3. erase first 4 bytes in both
  4. change hash is sha256(base + file_pos + change_type + data)
  5. get collision
nyxxxie commented 7 years ago

@fst3a is this fixed with sqlalchemy changes in feature/implement_project?

nanokatze commented 7 years ago

@nyxxxie no.