search

nyyManni / ejira

Emacs JIRA integration
GNU General Public License v3.0
255 stars 36 forks source link

Make autoloads know about the required macro #14

Closed niklaseklund closed 4 years ago

niklaseklund commented 4 years ago

I got errors with ejira when compiling the source code. It misstook helm-ejira--define for a function. I looked around and found this entry in the manual: https://www.gnu.org/software/emacs/manual/html_node/elisp/Autoload.html

"If you write a function definition with an unusual macro that is not one of the known and recognized function definition methods, use ;;;###autoload (autoload 'foo "myfile")"

The macro helm-ejira--define is not ordinary so errors occurred when trying to compile. Hence I made these changes.

nyyManni commented 4 years ago

Thank you for helping out!

Adding ejira to melpa is still a work in its early stages so I hadn't tried byte-compilation yet. But when I'll eventually get there I would have run into this issue.