Feature: add "open in external browser" method

nyyManni / ejira

Emacs JIRA integration

GNU General Public License v3.0

255 stars 36 forks source link

Feature: add "open in external browser" method #39

Closed mbafford closed 2 years ago

mbafford commented 3 years ago

Maybe this isn't the Emacs way to add this into the package since it's pretty easy to write - once I learned enough elipsp to figure out how.

Something like this:

(defun ejira-open-issue-in-external-browser ()
  "Opens the currently focused issue in an external browser"
  (interactive)
  (browse-url (format "%s/browse/%s" jiralib2-url (ejira-issue-id-under-point))))

Seems like it'd be useful to have in the mainline project.

nightscape commented 3 years ago

I just wrote the exact same function (by copying it from org-jira and adapting) 😆 @mbafford Would be good creating a PR for it. Do you wanna go ahead, or shall I?

mbafford commented 3 years ago

Go for it!

nightscape commented 3 years ago

Merged in https://github.com/nyyManni/ejira/pull/41 @mbafford you can close this

nightscape commented 2 years ago

@mbafford @nyyManni this can be closed :)