search

nyyr / MylunesChampions

WoW Addon: Don't underestimate your little critters!
GNU General Public License v3.0
0 stars 0 forks source link

Use custom companion pet names rather than default pet name/species #4 #2

Open nyyr opened 6 years ago

nyyr commented 6 years ago

slippycheeze created this issue Dec 15, 2013

What steps will reproduce the problem? 1. Give a pet a custom name. (eg: rename your "Stinky Skunk" to "McStinkyPants" in the UI) 2. Summon it. 3. Run /pe or otherwise generate an emote.

What is the expected output? What do you see instead?

I saw this:

Larelina's companion Stinky Skunk loves you.

I expected to see this:

Larelina's companion McStinkyPants loves you.

What version of the product are you using?

Version: 0.8.1 X-Date: $Date: 2013-09-11 21:40:10 +0000 (Wed, 11 Sep 2013) $ X-Curse-Packaged-Version: v0.8.1

Please provide any additional information below.

This is fixed by changing util_companions.lua:153 in function MylunesChampions:GetCurrentCompanion() to return the customName if available; something like this: return customName or petName, creatureID where you currently return petName, creatureID.

nyyr commented 6 years ago

nyyr posted a comment Dec 16, 2013 Edit Delete

Thanks for the suggestion. ETA maybe in January.

nyyr commented 6 years ago

slippycheeze posted a comment Dec 16, 2013

Would you accept a patch if I tested and submitted it? Do you prefer some method other than attached here? I can definitely test the fix and make sure it works. :)

nyyr commented 6 years ago

nyyr posted a comment Dec 17, 2013 Edit Delete

I think I'm able to add this to my next commit (since you already were quite detailed). Testing is still necessary and needs to consider emotes targeted at your companion.