search

nzakas / cssembed

A tool for embedding data URIs in CSS files.
http://www.nczonline.net/
389 stars 30 forks source link

Max URI length #20

Closed fearphage closed 13 years ago

fearphage commented 13 years ago

Added a param to specify max URI length

-u, --maxuri length

This addresses half of issue #6.

fearphage commented 13 years ago

Related: Prevented the case where empty mhtml headers were added to the file.

nzakas commented 13 years ago

I finally got around to looking at this. The changes look good but they're causing two unit tests to fail. That either means the changes broke some existing functionality or changed the functionality such that the tests are no longer valid. Can you take a look?

fearphage commented 13 years ago

Can you confirm that they were passing before this change?

nzakas commented 13 years ago

Yes, and you can too my switching back to the current state of my repository.

tivac commented 13 years ago

Fixed the tests, sorry about all the Git noise Nicholas.

Not quite sure if this was better or worse than the pull request in #25 but figured it was at least a bit more appropriate a venue since Phred did the majority of the work.

nzakas commented 13 years ago

Cool thanks. I'll take a look when I get a free second.

nzakas commented 13 years ago

Merged in.