search

nzamani / sap-cloud-connector-docker

SAP Cloud Connector in Docker
76 stars 55 forks source link

End-user license agreement #1

Open Peter42 opened 6 years ago

Peter42 commented 6 years ago

Display/Accept of EULA is skiped for SCC

https://github.com/nzamani/sap-cloud-connector-docker/blob/41c10eb39d8526e0a1930ef83684ef56fdbf1dc2/Dockerfile#L30

and SAP JVM https://github.com/nzamani/sap-cloud-connector-docker/blob/41c10eb39d8526e0a1930ef83684ef56fdbf1dc2/Dockerfile#L31

nzamani commented 6 years ago

Well, it's explicitly (or implicitly?) accepted in order to allow seamless docker-like automation. I see the following options:

  1. I remove the automation (the 2 wget calls) and introduce a manual step

    • forcing the user
      • to go to the dev tools website
      • download both the files manually + accept EULA
      • and put the file into a given folder next to the Dockerfile
    • then the Dockerfile would pick up the files from the folder

  2. Add a disclaimer that "by using the Dockerfile your agree to the SAP EULA..."

@Peter42 Am I right guessing you want me to use Option 1? I'd be fine with that, but this would lead to a bad dev experience for the SAP dev community. I implemented this only for best possible dev experience in order to show some cool stuff, and not to skip EULA (and it's not skipped, it's explicitely accepted in the code).

Peter42 commented 6 years ago

Ok, you're right, it's not skipped, badly formulated by me. The point is: Your code explicitly accepts the EULA on behalf of the user, without informing the user about that (or asking for permission).

I don't actually care what you do and I'm not a lawyer myself and therefore not the most competent person when it comes to legal topics. Just wanted to point that out. Maybe it's better to change it before someone who actually cares sues you.