nzbgetcom / nzbget

Efficient usenet downloader
https://nzbget.com
GNU General Public License v2.0
355 stars 16 forks source link

Tests fail to build with -DDISABLE_PARCHECK=yes #393

Closed sbraz closed 2 months ago

sbraz commented 2 months ago

Is there already an issue for your problem?

NZBGet Version

v24.3-stable

Platform

Linux/Docker

Environment

OS: Gentoo ~amd64

Current Behavior

The build fails with:

FAILED: tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/FileSystem.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/FileSystem.cpp.o -MF tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/FileSystem.cpp.o.d -o tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/FileSystem.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/FileSystem.cpp
In file included from /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/FileSystem.h:28,
                 from /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/FileSystem.cpp:23:
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main/Options.h:25:10: fatal error: NString.h: No such file or directory
   25 | #include "NString.h"
      |          ^~~~~~~~~~~
compilation terminated.
[89/217] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/connect -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/extension -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/feed -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/frontend -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/nntp -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/nserv -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/postprocess -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/queue -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/remote -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/system -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT CMakeFiles/nzbget.dir/daemon/util/ScriptController.cpp.o -MF CMakeFiles/nzbget.dir/daemon/util/ScriptController.cpp.o.d -o CMakeFiles/nzbget.dir/daemon/util/ScriptController.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp: In member function ‘void ScriptController::StartProcess(int*, int*)’:
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:660:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  660 |                 write(1, "\n", 1);
      |                 ~~~~~^~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:664:22: warning: ignoring return value of ‘int chdir(const char*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  664 |                 chdir(workingDir);
      |                 ~~~~~^~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:671:30: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  671 |                         write(1, "[WARNING] Fixing permissions for", 32);
      |                         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:672:30: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  672 |                         write(1, script, strlen(script));
      |                         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:673:30: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  673 |                         write(1, "\n", 1);
      |                         ~~~~~^~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:681:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  681 |                 write(1, "[ERROR] Could not start ", 24);
      |                 ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:682:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  682 |                 write(1, script, strlen(script));
      |                 ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:683:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  683 |                 write(1, ": ", 2);
      |                 ~~~~~^~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:685:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  685 |                 write(1, errtext, strlen(errtext));
      |                 ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/ScriptController.cpp:686:22: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  686 |                 write(1, "\n", 1);
      |                 ~~~~~^~~~~~~~~~~~
[90/217] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o -MF tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o.d -o tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Benchmark.cpp
FAILED: tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o -MF tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o.d -o tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Benchmark.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Benchmark.cpp
In file included from /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/FileSystem.h:28,
                 from /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Benchmark.cpp:24:
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main/Options.h:25:10: fatal error: NString.h: No such file or directory
   25 | #include "NString.h"
      |          ^~~~~~~~~~~
compilation terminated.
[91/217] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/connect -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/extension -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/feed -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/frontend -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/nntp -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/nserv -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/postprocess -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/queue -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/remote -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/system -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT CMakeFiles/nzbget.dir/daemon/queue/Scanner.cpp.o -MF CMakeFiles/nzbget.dir/daemon/queue/Scanner.cpp.o.d -o CMakeFiles/nzbget.dir/daemon/queue/Scanner.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/queue/Scanner.cpp
[92/217] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o -MF tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o.d -o tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Log.cpp
FAILED: tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_JSON_DYN_LINK -DBOOST_JSON_NO_LIB -DHAVE_CONFIG_H=1 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3_build -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3 -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/regex -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/lib/yencode -I/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main -isystem /usr/include/libxml2  -O2 -pipe -march=native -std=c++17 -MD -MT tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o -MF tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o.d -o tests/util/CMakeFiles/UtilTests.dir/__/__/daemon/util/Log.cpp.o -c /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Log.cpp
In file included from /var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/util/Log.cpp:23:
/var/tmp/portage/net-nntp/nzbget-24.3/work/nzbget-24.3/daemon/main/Options.h:25:10: fatal error: NString.h: No such file or directory
   25 | #include "NString.h"
      |          ^~~~~~~~~~~
compilation terminated.

Expected Behavior

The build should succeed

Steps To Reproduce

Build nzbget wiht -DENABLE_TESTS=yes -DDISABLE_PARCHECK=yes

Logs

No response

Extra information

No response