nzixuan / pe

0 stars 0 forks source link

Duplicate exams can be added to an student #4

Open nzixuan opened 2 years ago

nzixuan commented 2 years ago

It is possible to add exams to a student with the same date/time and even the same name to a student. Even though it should not be possible to have the same-named exam or exams during the same time.

student -ae 1 s/Math d/2021-12-20 14:00

Screenshot 2021-11-12 at 4.52.08 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Duplicate

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate exams can be added

If I key in "student -ae 1 s/Math d/2020-02-29 14:00" 3 times, 3 instances of the same exam are input into the student's exam list. There should be a check for duplicate entries!

Screenshot 2021-11-12 at 4.33.16 PM.png


[original: nus-cs2103-AY2122S1/pe-interim#2048] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Downgraded: Medium -> Low.

While the bug is correct, it should not cause a lot of inconvenience to users. Exam dates are for the users to help their students score better, by noting the exams their students have upcoming.

Duplicate exams can be seen in the list, and not affect the user's usage of the app. For example, if the user notes that his student has an exam next Friday, it does not affect the user much as the user will be preparing that student for that exam anyway.

Also, as a user of the app, it is unlikely that a student has many exams that are of interest to the user. They may usually have 3-6 exams per semester that are related to the topics the user teaches. Looking through the list, a duplicate exam could be spotted quite easily.

However, it is definitely a good feature to include, hence it is accepted but downgraded in severity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]