search

nzzdev / Q-quiz

MIT License
0 stars 0 forks source link

Feature number poll #140

Closed KiaraEdTech closed 3 years ago

KiaraEdTech commented 3 years ago

This adds a number poll, which is an alternative of the number guess with no correct answer. Since it is only in one project now, I attempted to separate the two instead of reworking the mechanism.

The tests were updated to cover number poll. The readme was updated to include number poll. Fixture has been added (single-number-poll).

Note on svgHelpers.js : these are the functions from number guess that create svg results. Since these were used in number poll too, I extracted them into a separate file for clarity.

Number poll have no own style classes, it uses the styles of number guess.

manuelroth commented 3 years ago

This looks very good. I have tested it on staging and can confirm that it works as expected. I don't have any remarks. Well done @KiaraEdTech