o-lukas / homebridge-smartthings-tv

This is a plugin for Homebridge. It offers some basic functions to control Samsung TVs using the SmartThings API.
https://www.npmjs.com/package/@o-lukas/homebridge-smartthings-tv
MIT License
32 stars 2 forks source link

Rename device in Homekit #367

Closed jonbisch closed 4 months ago

jonbisch commented 4 months ago

Before opening the issue, have you...?

Describe Your Problem

When I rename the device in Homekit it changes back to the default name is Homebridge is restarted. Is there a way to force Homekit to use a different device name? It appears to always default back to Configured Name.

Logs

No response

If applicable, add screenshots to help explain your problem.

image

Environment Information

- Plugin Version:
- Homebridge Version: <!-- homebridge -V -->
- Node.js version: <!-- node -v -->
- NPM version: <!-- npm -v -->
- Operating System: <!-- Raspbian / Ubuntu / Debian / Windows / macOS / Docker / hb-service -->
o-lukas commented 4 months ago

Sorry for late response: does the Homebridge UI show the name correct after restarting? So problem is only in HomeKit?

jonbisch commented 4 months ago

Thanks for the reply. Homebridge keeps the correct value in the Name field when I rename it even after restarting, but what I see in HomeKit is the Configured Name value from Homebridge not Name. I've also tried clearing cached devices then re-adding it just to be sure.

The only way I can find to change the name that displays in HomeKit is to change it directly in HomeKit, but it reverts back the Configured Name value when Homebridge is restarted and Configured Name can't be changed.

o-lukas commented 4 months ago

This might be the case because the TVs are published as external accessory. So they can not be cached as normal accessory would get in HomeBridge.

I will try to add an option to change the configured name of a TV in the config file, so you can change it there and it will not get lost.

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

o-lukas commented 4 months ago

I've created a new release. Please check new config property nameOverride

jonbisch commented 4 months ago

Looks like that did the trick, Thank you so much!