o-marshmallow / PocketCHIP-pocket-home

PocketCHIP home screen: shows status, opens programs, changes settings
128 stars 32 forks source link

Make fewer assumptions about aspect ratio #26

Open singpolyma opened 7 years ago

singpolyma commented 7 years ago

pocket-home happily scales to different window sizes, but it strongly assumes the aspect ratio of the original pocketCHIP screen. We can probably tweak the grid to behave a bit better in these cases.

thearkadia commented 6 years ago

@singpolyma I'm using pocket-home on a vertical screen and its not scaling well. Any tips on making everything scale better?

singpolyma commented 6 years ago

@thearkadia try the linked PR branch?

thearkadia commented 6 years ago

@singpolyma I did. Maybe since i installed marshmallow's version first it didnt overwrite the settings? Also, on your readme for building from source you forgot to link your branch instead of marshmallows

singpolyma commented 6 years ago

try just deleting all the configs and run the version you built from my branch? I forget if config has an effect. Oh, wait, there is a "horizontal" : false config or something that you can set with my branch to make it even better (does 2x3 instead of 3x2)

thearkadia commented 6 years ago

So I ended up formatting the sd card and reinstalling raspbian and installing just your branch but i get a pop up menu https://imgur.com/a/UTFg5 if I press "Yes" it appears again and if I press "No, let me do it" I get this error "cp: cannot stat '/usr/share/pocket-home/config.json' : No such file or directory.

singpolyma commented 6 years ago

hmm. how did you install it? I think that file should exist -- though if you run it locally in the directory you compiled in it might also find it there? Or just copy the config.json from the git repo to that path

thearkadia commented 6 years ago

i built it from the sources following the instructions. Although instead of doing git clone --recursive https://github.com/o-marshmallow/PocketCHIP-pocket-home/

I did git clone --recursive https://github.com/singpolyma/PocketCHIP-pocket-home/

running it inside the folder doesn't work and I can't seem to find the config.json in the git repo

singpolyma commented 6 years ago

ok, you can't just clone. you need to git checkout more-dymanic-size to get the branch.

The default config on that branch is https://github.com/singpolyma/PocketCHIP-pocket-home/blob/more-dynamic-size/assets/config.json

singpolyma commented 6 years ago

Looks like the config you want to add to the root level is "direction": "vertical" to get some of the improvements, though should be better even without that :)

thearkadia commented 6 years ago

git checkout more-dymanic-size

gives me

error: pathspec 'more-dymanic-size' did not match any file(s) known to git.

singpolyma commented 6 years ago

sorry, more-dynamic-size - the branch name from the PR :)

thearkadia commented 6 years ago

hm, still isnt working I tried manually putting the config file in there. I get the same error. If I restart the pi and run $ pocket-home and press "No, let me do it" I get

(process:711): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:711): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(process:711): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:711): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(process:711): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:711): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(process:711): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:711): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Segmentation fault

If i were doing this for the first time would I do,

  git clone --recursive https://github.com/singpolyma/PocketCHIP-pocket-home/
  git checkout more-dynamic-size
  make
  make devinstall
  sudo systemctl restart lightdm

or is there a command after git checkout that I should do?

thearkadia commented 6 years ago

@singpolyma any chance you could write\test your own instructions since the ones on the README don't include anything for you screen fix. After several installs I got it running but it would be really convenient if the instructions were laid out instead of having to test and break things over and over xD

singpolyma commented 6 years ago

I mean, no one should have to build my version eventually -- the hope is that the PR gets accepted and becomes part of the normal version :)

thearkadia commented 6 years ago

@singpolyma the PocketChip team has seemingly dissapeared and hasn't been replying to email or forum posts for a long time now and I'm not sure if @o-marshmallow is around either =\

btw the device we're using your branch for is https://github.com/thearkadia/The_Ark :)

thearkadia commented 6 years ago

@singpolyma now that Next Thing Co. Is officially dead could you have your own fork for your version for those who want to use pocket-home on other devices?