search

o0111 / ruralcafe

Automatically exported from code.google.com/p/ruralcafe
0 stars 0 forks source link

RequestHandler enumeration for status changes #15

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The status codes are not very useful across the files in the source. A bunch of 
different classes and at least the two handlers are using it for different 
purposes. So there isn't really any consistency and its not clear what the 
different codes mean for the code logic and in the logging for analysis.

Original issue reported on code.google.com by shouldab...@gmail.com on 10 Oct 2010 at 7:34

GoogleCodeExporter commented 8 years ago 
The enumeration is used in LocalRequestHandler, RequestHandler, 
RemoteRequestHandler, RCRequest adn RCLocalProxy. What are the different 
puposes?

I noticed that each occurence is explicitly casted to an int. Wouldn't it be 
better to stick to the enum type where possible?

Original comment by satiaher...@gmx.de on 21 Apr 2013 at 6:52

GoogleCodeExporter commented 8 years ago 
I removed the casts and changed some method and field types accordingly. Now 
the names are printed to and read from the logs.

As there is still only one enum type, I don't know if there is still something 
to do on this issue. As I see it at the moment, we don't really need another 
one. Comments?

Original comment by satiaher...@gmx.de on 1 May 2013 at 10:47

GoogleCodeExporter commented 8 years ago

Original comment by satiaher...@gmx.de on 1 May 2013 at 10:55

GoogleCodeExporter commented 8 years ago 
Sounds fine for now then.

Original comment by shouldab...@gmail.com on 1 May 2013 at 11:54

GoogleCodeExporter commented 8 years ago 
OK. I set it to fixed.

Original comment by satiaher...@gmx.de on 1 May 2013 at 2:32