Please test at PHP 8.2, if this project wants

o0h / php-ast-check-diff

This is an action to check modifications in PHP scripts based on Abstract Syntax Tree (AST).

MIT License

3 stars 1 forks source link

Please test at PHP 8.2, if this project wants #7

Closed sasezaki closed 1 month ago

sasezaki commented 10 months ago

Currently, this project's composer.json

    "require": {
        "php": ">8.2",

In composer, it means >8.2.0.0-stable https://getcomposer.org/doc/articles/versions.md#stability-constraints

So, this also means it could be install 8.2.1 or above.

If you really want support PHP 8.2, please add QA checks into github actions.

sasezaki commented 10 months ago

Personally, I recommend using "PHP Minor version range specification constraint" (eg. "php": "~8.1.0 || ~8.2.0 || ~8.3.0" ) (see https://zenn.dev/top/articles/9f0d8a25ccef03 )

o0h commented 8 months ago

@sasezaki Thank you for your kind and detailed report!! I apologize for the delayed response.

I plan to address this issue soon (likely within this week) and will decide on the course of action to take, which I think will involve the following changes:

Update the target operation version to 8.3 or higher
- ~8.3.0
As stated in the README, the primary use case is not intended to be "adding as a package to an existing project", so we will be taking an aggressive approach to support.
The reason it was set to 8.2 originally was due to my personal environment not being ready for 8.3 yet. It was not a deliberate choice.
- In relation to this, we will also be removing the polyfill discussed in #6.