search

o1-labs / docs2

Docs website for the Mina Protocol.
https://docs.minaprotocol.com
90 stars 133 forks source link

Tutorial 7: Oracles example inconsistent to other tutorials #696

Open qwadratic opened 1 year ago

qwadratic commented 1 year ago

Tutorial 7 smart contract uses this.requireSignature in the init() method. Deploy transaction is signed, and the explanation states that we signed it because init() invokes this function.

However, HelloWorld example doesn’t use requireSignature, though keeping sign() in deployment script. Either content or code should be updated.

barriebyron commented 1 year ago

@jackryanservia can you evaluate please?

mitschabaude commented 1 year ago

Both are wrong IMO, they should use neither sign() nor requireSignature() when calling a contract method

LuffySama-Dev commented 12 months ago

If I am not wrong requireSignature will be used mostly during Verification process right ? https://docs.minaprotocol.com/zkapps/o1js-reference/classes/SmartContract#requiresignature

Also, we can remove it right from tutorial without causing any issue ?