search

o1-labs / o1js

TypeScript framework for zk-SNARKs and zkApps
https://docs.minaprotocol.com/en/zkapps/how-to-write-a-zkapp
Apache License 2.0
477 stars 105 forks source link

Mina-signer: mention private key conversion function when `PrivateKey.fromBase58()` fails #1568

Open mitschabaude opened 2 months ago

mitschabaude commented 2 months ago

Several users of mina-signer have been trying to use it with out of range private keys and ran into an error.

That's why we introduced a conversion function to support these private keys. That function should be mentioned in the error message, whenever PrivateKey.fromBase58() fails with an error containing

Scalar: inputs larger than XXX are not allowed, got YYY
emirsoyturk commented 3 weeks ago

Hey I would like to help this issue if it is still available. @mitschabaude

mitschabaude commented 3 weeks ago

@emirsoyturk yes that would be great! It's available

emirsoyturk commented 3 weeks ago

Just opened a PR