o1-labs / o1js

TypeScript framework for zk-SNARKs and zkApps
https://docs.minaprotocol.com/en/zkapps/how-to-write-a-zkapp
Apache License 2.0
475 stars 105 forks source link

Enable signing twice in both o1js and mina-signer #1622

Open mitschabaude opened 2 months ago

mitschabaude commented 2 months ago

Currently, we use dummy signatures when signing and not having the right private key.

When signing again, this time with the private key, but a dummy signature is there, we just back out and leave it in place. This unnecessarily prevents very basic workflows like signing with one key, then signing with another key.

We could just override any previous signatures.

discord discussion: https://discord.com/channels/484437221055922177/1231857401578389554/1232424829681012780