search

o1-labs / o1js

TypeScript framework for zk-SNARKs and zkApps
https://docs.minaprotocol.com/en/zkapps/how-to-write-a-zkapp
Apache License 2.0
531 stars 121 forks source link

Remove account update limit for zeko #1910

Open youtpout opened 5 days ago

youtpout commented 5 days ago

Hello, Currently o1js has been designated for mina and relies on the current mina configuration when generating a proof to know if it will work on Mina, if the transaction is too expensive an error is returned: Error: The transaction is too expensive, try reducing the number of AccountUpdates that are attached to the transaction.

But on zeko you don't have this kind of limit, if you want to create a proof that exceeds the number of account updates allowed by Mina, you have to modify this file: O1js constants and put a bigger value to COST_LIMIT.

It would be nice to have a parameter in o1js to remove this limit when you want to generate a proof for zeko.

45930 commented 3 days ago

@youtpout this sounds like a reasonable config option. Would you want to open a PR? I think the right API would be to allow the user to define custom costs and max cost config to the Mina.Network config, so if the network is configured for zeko, verifyTransactionLimits will use different values than if it is configured for Mina.