search

o1-labs / proof-systems

The proof systems used by Mina
https://o1-labs.github.io/proof-systems/
Apache License 2.0
387 stars 89 forks source link

Soundness of syscall read preimage #2335

Open dannywillems opened 2 weeks ago

dannywillems commented 2 weeks ago 
          Nit (not for this PR): a good documentation, IMO, is also a documentation that describes what the parameters of the function does, and in particular, explains why there are some unused parameters when it is in the implementation of a trait.

For instance, here, I would have explained why _addr and _len are unused in the constraints side, when it is used in the witness. And also explain what pos is expected to be.

_Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/2274#discussion_r1642929659_

Also:

dannywillems commented 1 week ago

Left some comments on the PR !2355 we should have a look at later.