search

o1-labs / proof-systems

The proof systems used by Mina
https://o1-labs.github.io/proof-systems/
Apache License 2.0
410 stars 91 forks source link

[o1vm] Ensure the instruction passed into the interpreter is the one pointed to by the IP #2573

Open Fizzixnerd opened 2 weeks ago

Fizzixnerd commented 2 weeks ago

Or otherwise refactor it so no instruction is passed in, and we just use the opcode from the IP.

This is in, for instance, https://github.com/o1-labs/proof-systems/blob/master/o1vm/src/mips/interpreter.rs#L987 the interpret functions for the instructions.

varun-doshi commented 2 weeks ago

Is this still open? If so, I would like to take this up. Some more context would be helpful

Fizzixnerd commented 1 week ago

Hi there!

I'm currently working on this issue, sorry! This issue is part of the as-yet-unfinished o1vm work that we are doing, so I think it would be difficult to give more context until we've actually released the feature it's a part of. Sorry, I meant for the tag to be for people working on the VM already, I didn't mean to confuse!

varun-doshi commented 1 week ago

No issues Will look for other issues to get started