search

o1-labs / rfcs

RFCs for everything O(1) Labs
4 stars 4 forks source link

[0011] zkApp-CLI enhancements for local lightnet management. #35

Closed shimkiv closed 8 months ago

shimkiv commented 11 months ago

Closes https://github.com/o1-labs/quality-and-testing/issues/139

MartinMinkov commented 11 months ago

Another question I have is related to fault tolerance. How should we plan around node failures? If a node fails, is there any restart policies that happen automatically? If not, could we detect node errors and preemptively fix them? Should we notify users iof these node failures right away? What strategy would you like to see?

shimkiv commented 11 months ago

Another question I have is related to fault tolerance. How should we plan around node failures? If a node fails, is there any restart policies that happen automatically? If not, could we detect node errors and preemptively fix them? Should we notify users iof these node failures right away? What strategy would you like to see?

@MartinMinkov absolutely makes sense but I'd extract it as task for later. For now I'd just add zk lightnet status simple command to see the network status (running/not running and if not then what was the issue if available). Today, if something will go wrong with Mina Daemon inside the container then this container will simply stop. I'll check if docker engine has any relevant hooks we can use in order to do some meaningful actions before container will die.

shimkiv commented 9 months ago

Implementation is ready, here is an Epic.

shimkiv commented 9 months ago

@bkase can you please approve it? Implementation differs a bit but not too much and in better way.