Closed shimkiv closed 3 weeks ago
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
Note for assignee: address TODO
in CI config: https://github.com/o1-labs/zkapp-cli/pull/662.
UPD: Done.
Smoke testing run against this branch: https://github.com/o1-labs/zkapp-cli/actions/runs/9970821097 Please refer to PR's description for the information about why it is not picked up.
Closes #645 Closes #650
Codecov
project can be found here: https://app.codecov.io/gh/o1-labs/zkapp-cliUnit
tests only.Unit
andSmoke
tests.Common unit tests
←Examples unit tests
←Smoke E2E tests
←Publish to NPM
.Smoke E2E tests
workflow being triggered for this PR, not publishing on NPM. But they will work once merged to default branch.Jest
will fail theUnit
tests execution in case if resultingcoverage
will be less thanconfigured threshold
.Unit
tests onmain
codebase changes./* istanbul ignore next */
) it either covered by E2E tests and needs to be covered by unit tests as part of tasks linked to this PR or it is tough to mock.127.0.0.1
andlocalhost
).Some issues faced during the tests implementation:
Jest
,Mocha
,native Node.js
test runner, all have issues when it comes toES
modules and async code mocking.Some parts of different tests could be optimized much better, but it would take another eternity to do so. I decided that for now we will only want to have unit tests in place working for us and take care of optimization later.
Unit
tests to be configured as mandatory pre-commit hook (alongside with the currently configured linter)?