search

o19s / chorus-opensearch-edition

Chorus, now for OpenSearch!
Apache License 2.0
4 stars 1 forks source link

Removing exit that causes the quickstart to stop executing #25

Closed jzonthemtn closed 8 months ago

jzonthemtn commented 8 months ago

Removing exit that causes the quickstart to stop executing.

epugh commented 8 months ago

thanks. I assumed that this returned back to the caller? does a break need to be here versus an exit?

jzonthemtn commented 8 months ago

thanks. I assumed that this returned back to the caller? does a break need to be here versus an exit?

If it hits that exit 1, the whole quickstart.sh stops. I think we want it to continue on with the indexing?

epugh commented 8 months ago

ah... what do you think of the break ?

RasonJ commented 8 months ago

There is definitely weirdness with this logic on Windows. I'm still trying to figure out the magic combo, but in Windows wsl (which maybe I need to configure something like opening the port, etc), the wait for OS never ends, even though I can see OS running in the container. I usually just comment this script out before I try to index, and then just wait until I see the container running before I index.

jzonthemtn commented 8 months ago

@epugh break worked. The quickstart.sh kept running:

............Timeout waiting for 'green' OpenSearch status reached. Proceeding on.

[QUICKSTART] Creating ecommerce index, defining its mapping & settings