Fix login and redirect problem with Keycloak

drieschel commented 3 months ago

This PR fixes a problem when logging into quepid with Keycloak.

Description

Reverted same_site: :strict to same_site: :lax, which was introduced in v7.17.1.

Motivation and Context

With Firefox it was not possible to login into quepid and in Chrome the redirect after authentication in Keycloak did not work properly.

How Has This Been Tested?

Applied the fix in quepid instance and logging in over Keycloak worked again with Firefox as well as redirection in Chrome after successful authentication.

Screenshots or GIFs (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[] Improvement (non-breaking change which improves existing functionality)
[] New feature (non-breaking change which adds new functionality)
[] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[] I have read the CONTRIBUTING document.
[] I have added tests to cover my changes.
[x] All new and existing tests passed.

epugh commented 1 month ago

thank you, I think I have been experiencing this elsewhere...!

epugh commented 1 month ago

BTW, any thoughts on how to be able to restore the :strict or is it just not for us?

drieschel commented 1 month ago

I think it is not possible, because the Keycloak authentication form usually resides under a different domain. Just guessing, didn't deep dive into that topic.

o19s / quepid