o1egl / paseto

Platform-Agnostic Security Tokens implementation in GO (Golang)
MIT License
833 stars 34 forks source link

Add ability to store any type as claim in JSONToken #17

Closed o1egl closed 4 years ago

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 269


Changes Missing Coverage Covered Lines Changed/Added Lines %
json_token.go 44 61 72.13%
<!-- Total: 45 62 72.58% -->
Files with Coverage Reduction New Missed Lines %
json_token.go 3 81.48%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 255: -2.7%
Covered Lines: 480
Relevant Lines: 565

💛 - Coveralls
BRMatt commented 4 years ago

Thanks you for maintaining this library! Just wanted to note that this PR broke API compatibility for clients of JSONToken{}.Get(), as it now requires 2 arguments rather than just 1.

I'm not sure it helps much now that the PR has been merged into master, but I think the go mod convention for changing the public API is to cut a new major version?

o1egl commented 4 years ago

I know. I gonna release v2 after some refactoring. If you want to use it now, please stick to git commit instead of tags