Closed Timmimim closed 7 years ago
I understand your excitement, but please change the title of the PR to something more descriptive and consequently more useful.
So, I assume the tests are still under development. Looking forward to see updates on this PR.
Another question: _Why is SH_Script_Extract_Original_Paper_Before_Container-Start/extract_original_paper_from_ERC.sh
a shell script and not written in JavaScript?_
Tests are under development, I have not worked with Mocha before and am learning it now. Along with writing tests, I will change the name and structure of the current test-files
directory.
_extract_original_paper_from_ERC.sh_
was built as a shell script during development to speed up the task of, well, extracting the original paper from the image.tar file of any ERC.
It can be rewritten to JavaScript, of course, and I will do so ASAP.
Then, after rewriting the shell script into JS and writing tests, I will update the README.md file.
Well, if the shell script is only a util script for development, then I am fine with it being a shell script! It was just not clear to me if that script was targeted at developers or users.
I'd recommend leaving it a shell script then, but not documenting it in the main README not to confuse regular users... maybe add a developer readme, and put the shell script into a dir /etc
?
README.md
is updated, and test/
now includes a test for the check request handling in index.js
.
What I have done so far:
built a CLI tool that visually compares two HTML files, containing the same number of images, created from a .Rmd file;
built a Bash script which extracts the main.html from any ERC's image.tar file
image.tar
content to temp directory (piping output fromtar
totar
, and from there tocp
did not work)cp
, which tries to extracterc/main.html
original_papers
directory, while temp files of image are deletedNext planned steps will be:
README.md
to a reasonable level