Allow disabling of synchronised scrolling in the result view

o2r-project / o2r-UI

User interface for creating and examining Executable Research Compendia (ERC)

https://o2r.uni-muenster.de/

Apache License 2.0

3 stars 5 forks source link

Allow disabling of synchronised scrolling in the result view #183

Closed nuest closed 3 years ago

nuest commented 4 years ago

Sometimes, the documents differ to much for the synched scrolling to work. Then the reader should have the option to disable the synching so she can adjust manually.

Example: https://o2r.uni-muenster.de/#/erc/GWME2voTDb5oeaQFuTWMCEMveKS1MiXm

njakuschona commented 3 years ago

Implementation of the synced scrolling at https://github.com/o2r-project/o2r-UI/blob/master/ui/src/components/erc/Check/Comparison/Comparison.js#L39

Fmazin commented 3 years ago

I have implemented a checkbox which disables the sync scrolling if checked. And if it is unchecked the sync scrolling works again. The sync scrolling is still on by default when the result view is entered. Bildschirmfoto von 2020-12-07 16-45-23 Screenshot from Opera

This works fine on Opera and Chrome. However on Firefox the initial sync scroll does not work anymore. But if you check uncheck the box it will work. Keep in mind that the sync scroll in firefox does not function fully anyway.

Should this be fixed?

nuest commented 3 years ago

Yes, it should be fixed. I also find the negative phrasing not so understandable. What do you think about "Synchronise scrolling" with a checked box by default?