search

o2r-project / o2r-UI

User interface for creating and examining Executable Research Compendia (ERC)
https://o2r.uni-muenster.de/
Apache License 2.0
3 stars 5 forks source link

Add optional metadata form in ERC creation #203

Closed Fmazin closed 3 years ago

Fmazin commented 3 years ago

This PR should resolve #146.

With this pull request a fourth form page for the ERC creation is added. On this form page you can edit the DOI, the languages of the paper(ISO 639-1 codes) and the keywords. Full optional metadata page: Bildschirmfoto von 2021-02-26 21-12-21

They are also shown on the metadata overview on the ERC site: Bildschirmfoto von 2021-02-26 21-13-08

Checks

I have included a few checks for the metadata.

  1. The DOI is checked for validity: Bildschirmfoto von 2021-02-26 21-11-40

  2. The keywords should always be at least two characters long. Bildschirmfoto von 2021-02-26 21-10-36

    1. The codes must be from the ISO Standard. Bildschirmfoto von 2021-02-26 21-08-05
    1. The languages must be unique. Bildschirmfoto von 2021-02-26 21-09-27

If any of the checks are to much or a more general problem arises please let me know.

nuest commented 3 years ago

@NJaku01 please go ahead with the merge, ideally you can follow up with the mentioned tests right afterwards.

njakuschona commented 3 years ago

@nuest I tested the reset. I fixed some minor errors; the fixes are in #204. After @Fmazin reviewed these changes, I would merge them and merge the tests afterwards.