o2r-project / o2r-muncher

Node.js implementation of the ERC execution and job control part of the o2r web API
https://o2r.info/results
Apache License 2.0
2 stars 7 forks source link

Update display file of the substituted compendium "in place" #122

Open nuest opened 6 years ago

nuest commented 6 years ago

After a substitution is created, it is not enought to simply run a job. Instead, the files in the substituted compendium must be updated. At least the display file will be different if a different data file is used.

This could happen by starting a job "in place", or by copying the files back to the compendium directory. In any case, this requires a specific type of job that only shares some steps with a regular job. Required steps probably are image prepare, image build, image run, and copy file.

This job is started by the substituter. muncher and informer should just as well work for providing read access and live updates for these kinds of jobs.

With all this in place, the substituter can then provide a comparison between base display file and substitution display file, see o2r-project/o2r-muncher#121

MarkusKonk commented 6 years ago

User clicks on substitution

The user receives information that: Files are substituted The analysis has started/running/finished (including logs)

"Go to ERC" possible once the analysis is finished

What happens if the user closes the browser and comes back? Assuming that the analysis continues in the background: The list of compendia includes "substitution candidates" (different from normal candidates) which are currently running ERCs that emerged from a substitution. A click on them shows a popup/window with the current logs. The user can see which step is currently ongoing. This is the same if the analysis of the ERC failed. The user can see which step failed but does not get to the ERC view. We provide the user with a notification that the ERC will appear in the list once the analysis is finished.

nuest commented 6 years ago

Should the substituted files not also be displayed to the user? I.e. the client shows the substituted and original files both in the listing and potentially with some side-by-side view (which could even solve o2r-project/o2r-muncher#121)