Dominant language detection does not work very well (at least for js project)

o2sh / onefetch

Command-line Git information tool

https://onefetch.dev

MIT License

9.96k stars 272 forks source link

Dominant language detection does not work very well (at least for js project) #22

Closed autra closed 5 years ago

autra commented 5 years ago

Title says it all:

https://github.com/mrdoob/three.js/ gets detected as shell (should be javascript)
same thing for https://github.com/AnalyticalGraphicsInc/cesium/
same thing for https://github.com/iTowns/itowns/

Thanks for the project, it's a very cool idea :-)

o2sh commented 5 years ago

Javascript is not handled yet. So it only accounted for the lines written in shell.

I just need to find a cool ASCII logo for Javascript...

sdushantha commented 5 years ago

@o2sh

`............................`
`----------------------------.
`----------------------------.
`----------------------------.
`----------------------------.
`----------------------------.
`-------------::-----:/:-----.
`------------sMM+--yNMMMMh:--.
`------------sMM+-oMMs:/s+---.
`------------sMM+-:NMNhs/----.
`------------sMM+---ohmMMNs--.
`--------:/--sMM+--+:--:hMM/-.
`-------oMMhhNMN:-dMMdhhNMm:-.
`--------/shhyo:---/syhhy+---.
`............................`

o2sh commented 5 years ago

javascript

o2sh commented 5 years ago

It's a good start.

@autra: You can try again, but it should work now

autra commented 5 years ago

you guys have been quicker than me! @o2sh your proposition was exactly what I was trying to do.

Btw, how did you generate this ascii logo?

autra commented 5 years ago

Working like a charm! Thanks :-)

o2sh commented 5 years ago

Sorry, I didn't know you wanted to do it. There is an open issue #2 where you can submit better ASCII logos...or add new languages.

I used the logo of @sdushantha and customized it a bit.

Glad you like it :)