o2sh / onefetch

Command-line Git information tool
https://onefetch.dev
MIT License
10.39k stars 281 forks source link

New Language Request: [Fennel] #578

Open y-mx-b opened 2 years ago

y-mx-b commented 2 years ago

[Fennel]

Fennel is a Lisp that compiles to Lua. It combines the flexibility of Lisp with the speed and simplicity of Lua.

Logo

https://fennel-lang.org/logo.svg

Upstream support

y-mx-b commented 2 years ago

Made a pull request to the tokei repo for Fennel language support

o2sh commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

spenserblack commented 2 years ago

:cry: Looks like tokei hasn't had a merged PR for language support in a while. Perhaps the maintainer should be pinged to check if they're still planning to accept language PRs and make releases.

o2sh commented 2 years ago

I created an issue https://github.com/XAMPPRocky/tokei/issues/911

y-mx-b commented 2 years ago

My Fennel support pull request has just been merged into tokei's master branch. Are there any plans to use tokei branches other than official releases for onefetch?

spenserblack commented 2 years ago

Unless we decide not to publish on crates.io, I believe we need to use released versions for all of our dependencies. I don't think crates.io accepts crates that depend on repository links/branches.

o2sh commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

o2sh commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

spenserblack commented 2 years ago

@o2sh Do we have a policy for stale PRs that are blocked by external dependencies? Should we consider them stale or still valid?

o2sh commented 2 years ago

I think they're still valid, we can tag the issue with the "blocked: tokei" label for it to be exempted from stale.

spenserblack commented 1 year ago

Linking #1152 to PRs and issues that will probably be affected.