Lowering default data iterations

o355 / PyWeather

Viewing the weather in a CLI has never been this much fun. (ARCHIVED)

https://gitlab.com/o355/PyWeather

GNU General Public License v3.0

28 stars 8 forks source link

Lowering default data iterations #60

Open o355 opened 6 years ago

o355 commented 6 years ago

Lowering default data iterations in PyWeather for better readability. Before this gets started I will do a very conclusive study about how much data different terminals on different screens can render.

After that I'll decide on an iteration count that works well. Right now, the 5+ iteration method is only good for full-screen terminals.

To-do list:

[x] Find the right amount of iterations per data type
[ ] Implement the new default values into all setup scripts (issue #85 is taking care of this)
[ ] Somehow find a way to ask the user if they'd like to lower default iterations when in configupdate.py.

o355 commented 6 years ago

Work has started to begin on this "fix". I'll just be testing how many iterations on average we can see on a few computers.

ETA is 6/4 for a fix.

o355 commented 6 years ago

I've tested iterations on default sizes of terminals on KDE neon, Termux for Android, Windows 10 (PowerShell and the default command prompt), and through Bitvise SSH connecting to a Raspberry Pi.

I still need to test out macOS but here's what I've sound so far for default iterations:

1.5 day/10 day hourly: 2 iterations before prompt
10 day forecast: 3 iterations before prompt
Tide: 6 iterations before prompt
Historical hourly: 2 iterations before prompt
Yesterday hourly: 3 iterations before prompt

PowerShell had some crazy high numbers as to what it could fit, so it's an outlier in this experiment. I couldn't test hurricane data as there aren't any hurricanes floating around, but I may be able to down the road.

o355 commented 6 years ago

Hey sometimes the notes widget data just gets deleted, so the default iterations above is what we're sticking with. I'll still test macOS to see what works.

o355 commented 6 years ago

Here's a fun issue: For whatever reason there isn't any option for configuring iterations during config load. Will investigate more...

o355 commented 6 years ago

To complete this issue, we need to add code to separate out how many iterations occur for each data type. Right now multiple data types rely on a single variable.

There goes the thought of PyWeather 1.0.0 being ahead of schedule

o355 commented 6 years ago

MacOS does appear to be a bit on the lower side of the iteration table. 1 iteration for hourly data (but the 2nd one is entirely visible, just not the date).

Forecast data is 2 iterations. Tide data is 5-6 iterations,

On the bright side it's a solid 2 iterations for historical hourly. But then it's sad because 2.5 iterations for yesterday hourly.

I think I'll keep things the same for now.

BenjaminUrquhart commented 6 years ago

No, it didn't

On Fri, Jun 1, 2018 at 10:20 AM, o355 notifications@github.com wrote:

I think solving the "asking the user for lower iterations" inside of configupdate.py won't be an issue, as default number of iterations will already get implemented with new config variables.

Did that make sense

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/o355/PyWeather/issues/60#issuecomment-393895441, or mute the thread https://github.com/notifications/unsubscribe-auth/AXjru6we2fmSIZ84V3hRA5hrM3bLqKxDks5t4U2ogaJpZM4SADsA .