o3de / ROSConDemo

A robotic fruit picking demo project for O3DE with ROS 2 Gem
Other
70 stars 23 forks source link

Kraken_nav readme.md incorrectly states that Ubuntu 20.04 (Focal) is supported #230

Closed LB-HubertUberman closed 1 year ago

LB-HubertUberman commented 1 year ago

Describe the issue

The Packages subsection in ROS2 prerequisites section of the Kraken_nav README.md file states that Ubuntu 20.04 (Focal) or 22.04 (Jammy) are supported, while only the latter is actually supported by ROSConDemo.

Please note that this issue is considered as a Major.

Impacted page(s)

Kraken_nav README.md

Expected experience

The Kraken_nav README.md file states that only Ubuntu 22.04 (Jammy) is supported.

adamdbrw commented 1 year ago

@LB-HubertUberman to be exact, navigation package is separate from the simulation and can run in a different console or on a different machine with any version of ROS which it builds with (either Galactic and Humble) and communicate with the simulation (which runs on Humble) through publish and subscribe. So it should work with Galactic in principle.

I do not believe it is a major issue since users land on the Demo page first, install the Humble (if not already there) and they are highly unlikely to install the older version as they go through the instructions and land on navigation README.

However, for the sake of clarity and simplicity, I will remove 20.04 from the README.

LB-HubertUberman commented 1 year ago

Issue verified as fixed on Development (https://github.com/o3de/ROSConDemo/commit/4deca9e39101480af908ea90ec0587f02ac83a6b)