search

o3de / ROSConDemo

A robotic fruit picking demo project for O3DE with ROS 2 Gem
Other
63 stars 21 forks source link

Update dockerfile for development to 2310 #263

Closed adamdbrw closed 6 months ago

adamdbrw commented 9 months ago

Once the branch is there on the release

michalpelka commented 7 months ago

Since we are close to release 2310.1, I will update it after release of this version.

jeremy-kubota commented 7 months ago

I'd also like to suggest that we keep the Dockerfile to contain revisions (hash or tag) instead of branches. If you use main branches and there are breaking API changes (such as how it is as of today), then the build will fail. If you pick a tag or hash, then it's at least a known good version.

jeremy-kubota commented 7 months ago

Might also consider just creating submodules of this ROSConDemo for o3de and o3de-extras or if you want to continue to have development branches of those sub repos then the vcs repos file works best because you can use versions of hash, tag or branch. Branch is good when you have to move all three repos along during development on a feature branch of the main repo.

michalpelka commented 6 months ago

Closing the issue, since it was resolved with updates to pull HEAD of the main branch for o3de and o3de-extras.