o3de / buongiorno-sample

Buongiorno Sample and Gem for O3DE
MIT License
4 stars 4 forks source link

Doesn't quite work with latest dev #1

Open nick-l-o3de opened 1 year ago

nick-l-o3de commented 1 year ago

I'm not sure what the contribution policy is but here's what needs to be done to make it work with latest dev.

Once this was done it started working for me just fine.


diff --git a/Gems/buongiorno/CMakeLists.txt b/Gems/buongiorno/CMakeLists.txt
index 1536c9b..e771ac4 100644
--- a/Gems/buongiorno/CMakeLists.txt
+++ b/Gems/buongiorno/CMakeLists.txt
@@ -4,5 +4,5 @@
 # which is generated when cmake is run
 # This path is the gem root directory
 if(PAL_TRAIT_BUILD_HOST_TOOLS)
-    ly_create_alias(NAME buongiorno.Builders NAMESPACE Gem)
+    ly_create_alias(NAME BuonGIorno.Builders NAMESPACE Gem)
 endif()
diff --git a/Project/project.json b/Project/project.json
index 9862c95..a187cb4 100644
--- a/Project/project.json
+++ b/Project/project.json
@@ -1,5 +1,5 @@
 {
-    "project_name": "BuonGIornoSample",
+    "project_name": "Buongiorno",
     "project_id": "{9579ef7f-9689-49af-ba1c-846bab6db72c}",
     "origin": "https://github.com/powervr-graphics/buongiorno-sample",
     "license": "MIT, https://opensource.org/licenses/MIT",
@@ -9,7 +9,7 @@
         "Project"
     ],
     "user_tags": [
-        "BuonGIorno",
+        "Buongiorno",
         "Sample",
         "Getting Started"
     ],
omarzohdi commented 1 year ago

Hi @lawsonamzn thanks for providing a fix for this! I've transferred ownership of the repo to O3DE a while back and I'm also not sure what the contribution policy is. I've opened a pull request from a fork of the project, but I'm not sure who would be responsible for approving it.