search

o3de / o3de-atom-sampleviewer

Atom sample viewer project for the Open 3D Engine
https://o3de.org
Other
31 stars 35 forks source link

Update screenshots for material pipeline #571

Closed jiaweig-amzn closed 1 year ago

jiaweig-amzn commented 1 year ago

Signed-off-by: jiaweig 51759646+jiaweig-amzn@users.noreply.github.com

There doesn't seem to be any rendering issues for those screenshots (see below). Some of those under threshold are also close to the boundary. So update them all. If the tests fail again, we may consider increase the tolerance level.

pipeline_diff

santorac commented 1 year ago

I would just update the threshold. If it was failing on your computer and you just update the screenshots, then it's going to fail on the computer of whoever captured the original screenshots.

jiaweig-amzn commented 1 year ago

I would just update the threshold. If it was failing on your computer and you just update the screenshots, then it's going to fail on the computer of whoever captured the original screenshots.

Ok. I'll increase the threshold by 1 level as well.