This change sets the default number of msaa samples in asv to 1, thereby turning it off for any platforms or samples that don't specify otherwise. Removing 'GetDefaultNumMSAASamples()' from SampleComponentManager, platforms and samples can instead call SetDefaultNumMSAASamples() if they want an msaa sample count other than one, making it so platforms don't have to implement the abstract function.
Updating all screenshots that were previously passing and were affected by the msaa change. All failing screenshots have been left but will need to be updated when their original issue is resolved.
A few special cases:
PassTest was testing attachments on several passes that were msaa specific. These have been changed to still test the various formats from before, but on passes more likely to be in every pipeline. This resulted in the removal of depthStencilMs.png, depthStencilResolve.png, and specularResolved.png
The MultiPipeline sample was explicitly setting the msaa count of it's second pipeline to 4, it now gets that information from the SampleComponentManager instead.
There were directional shadow issues on the Shadowed Sponza test that have disappeared. This is likely because fullscreen shadows assume default sample locations, and asv used to have custom sample locations.
Here's a list of all the screenshots that were not updated
This change sets the default number of msaa samples in asv to 1, thereby turning it off for any platforms or samples that don't specify otherwise. Removing 'GetDefaultNumMSAASamples()' from
SampleComponentManager, platforms and samples can instead callSetDefaultNumMSAASamples()if they want an msaa sample count other than one, making it so platforms don't have to implement the abstract function.Updating all screenshots that were previously passing and were affected by the msaa change. All failing screenshots have been left but will need to be updated when their original issue is resolved.
A few special cases:
Here's a list of all the screenshots that were not updated