search

o3de / o3de-azslc

Amazon Shader Language (AZSL) Compiler
Other
23 stars 14 forks source link

Added support for uint32_t, uint64_t, int32_t and int64_t #53

Closed martinwinter-huawei closed 2 years ago

martinwinter-huawei commented 2 years ago

Signed-off-by: Martin Winter martin.winter@huawei.com

Add support for all HLSL-supported integer datatypes that were missing

Supersedes #49 with proper support for the data types, including handling the literal suffixes.

martinwinter-huawei commented 2 years ago

Ran testsuite tests/launch_tests_linux.sh:

FINISHED. Total = 341
PASS = 339 /341
TODO = 2 /341
Missing EC = 0 /341
FAIL = 0 /341

which produces the same output as development (on 8010ac9f4d212c597ec365be8cbeae431ef02a2b)

jeremyong-az commented 2 years ago

@galibzon Can you suggest specific tests?

I would recommend at least checking that the types work in the context of a struct bound to an SRG constant buffer (reflected sizes are accounted for properly)

martinwinter-huawei commented 2 years ago

I added a few test cases, if you have anything more in particular in mind, do let me know.