search

o3de / o3de-extras

Other
58 stars 60 forks source link

Multiplayer Template possibly unused variable #684

Open jhanca-robotecai opened 2 months ago

jhanca-robotecai commented 2 months ago

The following fix was required on my Ubuntu to build the Multiplayer Template:

diff --git a/Templates/Multiplayer/Template/Gem/Code/Source/Components/NetworkAiComponent.cpp b/Templates/Multiplayer/Template/Gem/Code/Source/Components/NetworkAiComponent.cpp
index d8a7cb49..1865666b 100644
--- a/Templates/Multiplayer/Template/Gem/Code/Source/Components/NetworkAiComponent.cpp
+++ b/Templates/Multiplayer/Template/Gem/Code/Source/Components/NetworkAiComponent.cpp
@@ -16,8 +16,6 @@

 namespace ${SanitizedCppName}
 {
-    constexpr static float SecondsToMs = 1000.f;
-
     NetworkAiComponentController::NetworkAiComponentController(NetworkAiComponent& parent)
         : NetworkAiComponentControllerBase(parent)
     {

The variable is not always used and clang 14 on my Ubuntu 22.04 can clearly see that:

/devroot/projects/MultiplayerTemplate/Gem/Code/Source/Components/NetworkAiComponent.cpp:19:28: error: unused variable 'SecondsToMs' [-Werror,-Wunused-const-variable]
    constexpr static float SecondsToMs = 1000.f;

Originally posted by @jhanca-robotecai in https://github.com/o3de/o3de-extras/pull/680#pullrequestreview-1994465392