o3de / o3de-extras

Other
61 stars 61 forks source link

ROS2 Spawner add setting parent TF and modifiable service names #686

Closed adamkrawczyk closed 4 months ago

adamkrawczyk commented 5 months ago

What does this PR do?

Modifies the ROS2 spawner by:

Compared to the previous version, in the Editor the user can see Service names field Screenshot from 2024-04-23 12-55-52 Screenshot from 2024-04-23 13-09-12

How was this PR tested?

Tested on an external project and blank template project from o3de-extras. Tested by

  1. Open demo level and add ROS2 Spawner to the Warehouse entity
  2. Add test prefab to rosbot spawner
  3. Execute services on game mode
  4. Change service names and test again
zakmat commented 4 months ago

The CI failed in the Running Windows release phase (https://jenkins.build.o3de.org/blue/organizations/jenkins/o3de-extras/detail/PR-686/3/pipeline). It seems unrelated to this PR, can we re-run the CI check? I have rebased the changes on top of the current development.

michalpelka commented 4 months ago

@amzn-changml , could you override CI? If failed to report it success.

amzn-changml commented 4 months ago

I confirm the AR was ran after the force push and passed. Bypassing AR and merging in