o3de / o3de-extras

Other
58 stars 60 forks source link

Modified clock design, added new time source #707

Closed patrykantosz closed 2 weeks ago

patrykantosz commented 3 weeks ago

What does this PR do?

Changes the current design of the Clock source and adds new time source - the ROS 2 frame. Now there is only one Clock, ROS2Clock, which can be configured to work with different time sources. The Clock can also publish time to the /clock topic - this option is enabled by default. There are three TimeSources:

Clock can be configured via .setreg file or by passing --setreg flags in the command line. Example: ./build/linux_working/bin/profile/Editor --regset="/O3DE/ROS2/ClockType=ros2" --regset="/O3DE/ROS2/PublishClock=true"

How was this PR tested?

By checking if ROS 2 /clock topic is available and checking timestamps there for each of the time sources.

amzn-changml commented 2 weeks ago

This has passed AR, but the status is stuck on an older review: https://jenkins.build.o3de.org/blue/organizations/jenkins/o3de-extras/detail/PR-707/5/pipeline. Moving to override now.

o3de-issues-bot commented 2 weeks ago

Initial AR build failed https://jenkins.build.o3de.org/job/o3de-extras/job/PR-707/3/display/redirect. Status check rule override by amzn-changml