search

o3de / o3de-extras

Other
58 stars 60 forks source link

Update ROS 2 sensors base implementation #715

Closed michalpelka closed 1 day ago

michalpelka commented 1 week ago

What does this PR do?

It is a fix of an existing feature - a bus SensorConfigurationRequestBus that allows adjusting the behavior of ROS 2 sensors. It uses the ComponentEntityId pair as the key.

Also, a number of things were added or adjusted:

How was this PR tested?

It is only API, that 3rd party needs to integrate. As test, I've implemented a Gem to test it: https://github.com/RobotecAI/robotec-o3de-tools/pull/38 image

patrykantosz commented 1 week ago

@pijaro @MateuszWasilewski Could you please check if now everything is as it should be?

adamdbrw commented 1 week ago

Ping me tomorrow to review this please

patrykantosz commented 1 week ago

@adamdbrw Ping. As you wished.

pijaro commented 1 week ago

Tested with o3de development, profile config, project-centric, and with https://github.com/RobotecAI/robotec-o3de-tools/pull/38 - works as expected.

michalpelka commented 6 days ago

Since I am author, I cannot accept officially, but I support changes by @patrykantosz, thanks. For me it can be merged.

jhanca-robotecai commented 2 days ago

@amzn-changml Can you merge this PR? The AR was successful, but Github cannot see the status: https://jenkins.build.o3de.org/blue/organizations/jenkins/o3de-extras/detail/PR-715/3/pipeline/

amzn-changml commented 1 day ago

Confirmed AR passed. Merging this now