o3de / o3de

Open 3D Engine (O3DE) is an Apache 2.0-licensed multi-platform 3D engine that enables developers and content creators to build AAA games, cinema-quality 3D worlds, and high-fidelity simulations without any fees or commercial obligations.
https://o3de.org
Other
7.84k stars 2.21k forks source link

Feature Request: Add a Cancel option to "Fbx Settings (PREVIEW) > File progress" window #4604

Open LB-ArturZieba opened 3 years ago

LB-ArturZieba commented 3 years ago

Is your feature request related to a problem? Please describe. Currently there is no way of stopping .fbx files from being processed after starting to update them within the "Fbx Settings (PREVIEW)" window. This can be an issue if the processed .fbx files are big enough that processing takes a long time, or as is shown in the https://github.com/o3de/o3de/issues/3643 issue, the file cannot finish processing.

Describe the solution you'd like A Cancel option is added to the "Fbx Settings (PREVIEW) > File progress" window that allows to stop the .fbx file processing and return to the Editor.

Additional context Please refer to this comment: https://github.com/o3de/o3de/issues/3643#issuecomment-938587012 for additional information.

Fbx Settings' File progress window: FileProgress

AMZN-stankowi commented 2 years ago

@LB-ArturZieba I've refactored this window, is a cancel button something you would still want in the current version of this window?

Canceling isn't really something that can be done easily - this window isn't actually doing any processing, it's waiting on the Asset Processor to process the change that you just applied. It's preventing you from using the UX in that time period under the assumption that you will want to see the changes you've just made get finalized before you try to make additional changes. Otherwise, it would be confusing if you made changes, saved, the asset processor started processing the file, you make more changes, and then an error/warning/failure occurs, it could be confusing because your scene settings is showing changes that aren't applied to the processed file.

LB-ArturZieba commented 2 years ago

I cannot verify the current behavior entirely due to https://github.com/o3de/o3de/issues/12660. As mentioned in the description, this Feature Request was made due to https://github.com/o3de/o3de/issues/3643#issuecomment-938587012, as a way to prevent Editor from locking out while a big asset is being processed, or an issue occurs during processing that prevents it from finishing. As long as the new window does not lock the Editor while processing an asset, I think that this feature is no longer necessary.