o3de / sample-code-gems

Sample gems for how to create custom tools that extend the Editor, in both C++ and Python
Other
7 stars 6 forks source link

Made some improvements to the C++ Shape Example. #2

Closed cgalvan closed 2 years ago

cgalvan commented 2 years ago

Made some improvements to the C++ Shape Example after review:

ShapeExampleAdjusted

Signed-off-by: Chris Galvan chgalvan@amazon.com

amzn-leenguy commented 2 years ago

I'd like to add some white space left and right of the icons on the button labels (4 px each side is fine) , and also change the icons to 100% white. Since the visibility of the icons are low I can barely see them.

cgalvan commented 2 years ago

I'd like to add some white space left and right of the icons on the button labels (4 px each side is fine) , and also change the icons to 100% white. Since the visibility of the icons are low I can barely see them.

See above comment, I think I'm actually leaning towards removing this manual stylesheet set so we don't introduce bad patterns in the examples.

amzn-leenguy commented 2 years ago

I'd like to add some white space left and right of the icons on the button labels (4 px each side is fine) , and also change the icons to 100% white. Since the visibility of the icons are low I can barely see them.

See above comment, I think I'm actually leaning towards removing this manual stylesheet set so we don't introduce bad patterns in the examples.

Yeah I agree with that one actually. Good point. Buttons normally don't have icons. So just the standard button with label is preferred. Maybe add two buttons that are called Primary Button (blue) and Secondary Button (grey) that do nothing. (With the title: Example Buttons)

And then the rest of the buttons below it with just the label.