search

o3de / sample-code-gems

Sample gems for how to create custom tools that extend the Editor, in both C++ and Python
Other
9 stars 6 forks source link

Added Python version of the Shape Example. #3

Closed cgalvan closed 3 years ago

cgalvan commented 3 years ago

Added Python version of the Shape Example sample tool gem. It uses all the same Editor APIs as the C++ example.

ShapeExampleCppAndPython

Signed-off-by: Chris Galvan chgalvan@amazon.com

cgalvan commented 3 years ago

This is great. My one recommendation would be to see if all of the C++ buses, components, modules can be removed if the Python script does not depend on it. It would be great to have a general folder where extension scripts can be added and automatically activated without creating a gem. I'm not sure how that would impact including or compiling resources like the toolbar icon.

That would be great, I think it could definitely be pared down. You can already put a bootstrap.py under your engine root Editor/Scripts and that will get loaded when the Editor loads, so you could add things in there without needing to add a gem. Only advantage of gems is that they are more modular, so you could just add/remove through the Project Manager, vs. having to manually edit a file, but you're right in that it might be nice to have multiple samples in there as an example/starter.

cgalvan commented 3 years ago

Will submit this one as is, new PR to follow after feedback that will update both C++ and Python samples