o3de / sig-content

8 stars 12 forks source link

Adding Viewport Workflow #122

Closed LB-JaroslawGaweda closed 1 year ago

LB-JaroslawGaweda commented 1 year ago

Signed-off-by: Jarosław Gawęda 99716227+LB-JaroslawGaweda@users.noreply.github.com

Change summary

Adding the Viewport workflow file.

LB-JaroslawGaweda commented 1 year ago

@hultonha Thanks for the input. I'll wait if there are other suggestions from the reviewers and make the changes.

hultonha commented 1 year ago

@hultonha Thanks for the input. I'll wait if there are other suggestions from the reviewers and make the changes.

Thanks @LB-JaroslawGaweda 👍

hultonha commented 1 year ago

@benblack75 are you happy to remove you 'Request Changes' now? Thanks!

LB-JaroslawGaweda commented 1 year ago

I have added the mentioned workflow tasks from the comments.

@hultonha About the Match view, I could not find any information about this in documentation, I'm not quite sure if this is it, but I have added the Find the selected entity in the Viewport task.

hultonha commented 1 year ago

I have added the mentioned workflow tasks from the comments.

@hultonha About the Match view, I could not find any information about this in documentation, I'm not quite sure if this is it, but I have added the Find the selected entity in the Viewport task.

Hi @LB-JaroslawGaweda, hmm it unfortunately might not be documented but I was simply referring to this button

image

It would be good to check this behaves as expected (simply a bullet point to say 'Test match viewport' should be sufficient). Thanks!

hultonha commented 1 year ago

I think this is pretty much good to merge now @LB-JaroslawGaweda, let me know if there's any other changes you'd like to make and then I can get it merged 👍 Thanks!

LB-JaroslawGaweda commented 1 year ago

@hultonha I have added the Match Viewport workflow task and did minor fixes. If there are no more suggestions, it is ready to be merged.

hultonha commented 1 year ago

@hultonha I have added the Match Viewport workflow task and did minor fixes. If there are no more suggestions, it is ready to be merged.

Perfect! Thanks @LB-JaroslawGaweda, I'll merge now 👍

LB-JaroslawGaweda commented 1 year ago

Confirming that the pull request has been merged.