search

o3de / sig-graphics-audio

Documents and communications for the O3DE Graphics-Audio Special Interest Group
12 stars 14 forks source link

Reviewer Nomination: jhmueller-huawei #123

Closed jhmueller-huawei closed 10 months ago

jhmueller-huawei commented 1 year ago

Nomination Guidelines

Reviewer Nomination Requirements 6+ contributions successfully submitted to O3DE

  1. https://github.com/o3de/o3de/pull/10118
  2. https://github.com/o3de/o3de/pull/10141
  3. https://github.com/o3de/o3de-atom-sampleviewer/pull/472
  4. https://github.com/o3de/o3de/pull/11700
  5. https://github.com/o3de/o3de/pull/11701
  6. https://github.com/o3de/o3de/pull/14644
  7. https://github.com/o3de/o3de/pull/14719

100+ lines of code changed across all contributions submitted to O3DE

The first commit already manages that.

2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer

I hope to get the support of @moudgils and @thefranke.

Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month

Reviewer/Maintainer Nomination

Fill out the template below including nominee GitHub user name, desired role and personal GitHub profile

I would like to nominate: jhmueller-huawei, to become a Reviewer/Maintainer on behalf of sig-graphics-audio. I verify that they have fulfilled the prerequisites for this role.

Reviewers & Maintainers that support this nomination should comment in this issue.

thefranke commented 1 year ago

I support this nomination. Joerg is working on some rather large code chunks in the RHI and has gathered extensive knowledge, so they will make a great reviewer.

rgba16f commented 1 year ago

I support this nomination.

moudgils commented 1 year ago

I support the nomination

galibzon commented 1 year ago

I support the nomination

thefranke commented 11 months ago

Can we close this ticket @moudgils ?

moudgils commented 10 months ago

Closing this issue with the assumption that jhmuller is added to reviewer list

jhmueller-huawei commented 10 months ago

Yes, I've been added in the meantime :)